chore(x-goog-spanner-request-id): add SessionImpl.getChannel() and Options.RequestIdOption.(equals, hashCode) #3900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
odeke-em
force-pushed
the
x-goog-spanner-request-id-SessionImpl.getChannel
branch
from
f1c4977 to
6da90d0
Compare
odeke-em
changed the title
odeke-em
force-pushed
the
x-goog-spanner-request-id-SessionImpl.getChannel
branch
from
6da90d0 to
c822be3
Compare
odeke-em
force-pushed
the
x-goog-spanner-request-id-SessionImpl.getChannel
branch
2 times, most recently
from
4f13b14 to
21f755e
Compare
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
odeke-em
force-pushed
the
x-goog-spanner-request-id-SessionImpl.getChannel
branch
from
21f755e to
cad7fa9
Compare
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
…tions.RequestIdOption.(equals, hashCode) Implements channelId retrieval that'll then be used to plumb into x-goog-spanner-request-id's channel. Also implements Options.RequestIdOption.(equals, hashCode) Fixes googleapis#3899 Implement Options.RequestIdOption.(equals, hashCode)
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
odeke-em
force-pushed
the
x-goog-spanner-request-id-SessionImpl.getChannel
branch
from
e96ae47 to
6e65c3e
Compare
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
approved these changes
Jun 20, 2025
Comment on lines
+1101
to
+1104
| if (this.reqId == null || other.reqId == null) { | ||
| return this.reqId == null && other.reqId == null; | ||
| } | ||
| return this.reqId.equals(other.reqId); |
There was a problem hiding this comment.
tip for next time (just leave as-is for now);Java has a utility method for this:
java.util.Objects.equals(this.reqId, other.reqId);| @@ -464,17 +464,15 @@ public AsyncTransactionManagerImpl transactionManagerAsync(TransactionOption... | |||
|
|
|||
| @Override | |||
| public ApiFuture<Empty> asyncClose() { | |||
| XGoogSpannerRequestId reqId = | |||
| this.getRequestIdCreator().nextRequestId(1 /* TODO: channelId */, 0); | |||
| XGoogSpannerRequestId reqId = this.getRequestIdCreator().nextRequestId(this.getChannel(), 0); | |||
There was a problem hiding this comment.
Why is the initial attempt 0 here and in the close() method, but 1 in beginTransactionAsync()?
Comment on lines
+599
to
+601
| if (getIsMultiplexed()) { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
I assume that this means that we will be getting the channel that is being used in a different way for multiplexed sessions, and that this method is only intended for actual use with regular sessions.
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 20, 2025
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 22, 2025
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 22, 2025
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 23, 2025
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 23, 2025
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
odeke-em
added a commit
to odeke-em/java-spanner
that referenced
this pull request
Jun 26, 2025
…s prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR googleapis#3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR googleapis#3898 and PR googleapis#3915
olavloite
pushed a commit
that referenced
this pull request
Jun 27, 2025
…s prior code review suggestions (#3922) * chore(x-goog-spanner-request-id): propagate reqId into exceptions plus prior code review suggestions This change propagates the associated request-id into encountered exceptions and also addresses some code review questions from PR #3900. While here added some updates for AbstractReadContext.java and ResumableStreamIterator.java to set grounds for much smaller PRs in which we shall wholesomely test the changes. Curved out of PR #3898 and PR #3915 * Update tests with session.getRequestIdCreator * More plumbing * Update tests * Deal with the multiplex-session .getOptions null returns in getChannel * Correct array copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements channelId retrieval that'll then be used to plumb into x-goog-spanner-request-id's channel.
Fixes #3899